Skip to content

fix(fleet): fail seed and verify on HTTP errors - #454

Open
Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/fleet-http-errors
Open

Maya-Kid wants to merge 1 commit into
deeplethe:devfrom
Maya-Kid:fix/fleet-http-errors

Conversation

@Maya-Kid

Copy link
Copy Markdown

fleet.sh could report success when the master rejected a template registration or failed to delete the verification sandbox. Check the HTTP status for each master request and report non-2xx replies with the method, path, and response detail. The helper uses curl's existing status write-out support.

A rejected template registration now fails seed. Verification still attempts cleanup if the status lookup fails, and a failed cleanup exits nonzero and prints the probe sandbox ID.

Add six CLI regression tests to CI. They run real curl against a loopback server with SSH stubbed out and cover HTTP 409 on registration, HTTP 500 on cleanup or status, creation refusal, and the successful seed and verify paths. All six tests passed locally, along with bash syntax and diff checks.

Signed-off-by: dada-yan <BinjunYann@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant